STM32L475VG-DISCOVERY-IOT : add general demo #1

VVESTM · 2017-10-02T13:28:04Z

First demo on STM32L475VG-DISCOVERY-IOT board.
Demo is using those components :

Low energy Bluetooth (SPBTLE_RF)
temperature and pressure sensor (LPS22HB)
temperature and humidity sensor (HTS221)
Time Of Flight sensor (VL53L0X)

fpistm · 2017-10-04T12:36:06Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+/* Configure SPI3 for BLE
+  MOSI: PC12 (44), MISO: PC11 (43), SCLK: PC10 (42)
+  */
+SPIClass SPI_3(44, 43, 42);


Please, use PXn instead of pin numbering when higher than 15 (arduino header D0-D15).

fpistm · 2017-10-04T12:36:16Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+/* Configure BTLE pins
+      csPin = PD13 (50), spiIRQ = PE6 (57), reset = PA8 (31), led = LED4
+*/
+SPBTLERFClass BTLE(&SPI_3, 50, 57, 31, LED4);


fpistm · 2017-10-04T12:36:24Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+VL53L0X       *sensor_vl53l0x;
+
+TwoWire *dev_i2c;
+#define I2C2_SCL    D33


fpistm · 2017-10-04T12:38:52Z

This PR needs to have I2C using IT. See stm32duino/Arduino_Core_STM32#123

LMESTM · 2017-10-09T12:25:39Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

@@ -0,0 +1,427 @@
+/*
+
+ BTLE_sensors_tof_demo


what means tof ?

Time Of Flight.
Perhaps I need to rename the demo file. I can use BTLE_sensors_demo.ino as the Time Of Flight is "just" a sensor...

LMESTM · 2017-10-09T12:26:16Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+ This sketch provides a default demo to be used on STMicroelectronics Discovery L475VG IoT board.
+ It will use several components of the board :
+   * Low energy Bluetooth (SPBTLE_RF)
+   * temperature and pressure sensor (LPS22HB)


use upper case or low case in a consistent way for all lines

LMESTM · 2017-10-09T12:26:52Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+   http://www.st.com/en/evaluation-tools/b-l475e-iot01a.html
+
+ This sketch will launch 3 services on BLE : Acc, Environnemental and Time.
+ For testing the sketch, you can download on the playstore the "BlueNRG" application provided by


you can => you need to download BlueNRG application from playstore

LMESTM · 2017-10-09T12:28:48Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+ For testing the sketch, you can download on the playstore the "BlueNRG" application provided by
+ STMicroelectronics. (https://play.google.com/store/apps/details?id=com.st.blunrg for Android or
+ https://itunes.apple.com/fr/app/bluenrg/id705873549?mt=8 for Apple)
+ Enable Bluetooth and launch the application on your smartphone. Connect it to the BLueNRG device.


FIrst need to compile and download the example to the STM32 board right ?
No other action on the board before you can find the device in the application ?

yes, need to compile and download... of course ;)
No other action needed on the board. (Except move in front of the vl53l0x sensor to move the cube.)

just would be good to mention it to know what needs to be started first

LMESTM · 2017-10-09T12:31:27Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+#include <tof_gestures_TAP_1.h>
+
+/* Configure SPI3 for BLE
+  MOSI: PC12 (44), MISO: PC11 (43), SCLK: PC10 (42)


I don't think 42 / 43 /44 values are really useful

LMESTM · 2017-10-09T12:39:41Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+
+void loop() {
+
+  BTLE.update();


what does BTLE.update ?

Same as official example.

LMESTM · 2017-10-09T12:41:32Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+  }
+
+  if(swipe_detected()){
+    count_swipe = 20;


explain this hard coded value of 20

just used to see an effect on the cube. On each swipe detected, we will perform 20 updates of the cube position.

I understand, but would be worth a comment in the code to explain what it does and what happens if user changes it

LMESTM · 2017-10-09T12:41:41Z

examples/STM32L475VG-DISCOVERY-IOT/BTLE_sensors_tof_demo/BTLE_sensors_tof_demo.ino

+  if(count_swipe > 0){
+    switch(axis_to_update){
+      case UPDATE_AXIS_X:
+        p_axes->AXIS_X += 100;


explain the 100 value choice

Arbitrary value to move the cube. Same as "official" BTLE example

again worth a comment .. I think if I ask questions, maybe other users will as well

LMESTM · 2017-10-09T12:43:40Z

README.md

@@ -1,2 +1,10 @@
 # STM32Examples
 Provides several examples for the Arduino core for STM32 MCUs.
+For the complete description of each example, please refer to the comments at the beginning of each .ino file.


I understand the rational but can't we have as well a short description with picture in the example forlder of examples/STM32L475VG-DISCOVERY-IOT ?

LMESTM · 2017-10-09T12:44:25Z

README.md

+Examples for STM32L475VG-DISCOVERY board :
+  * BTLE_sensors_tof_demo.ino :
+	* get environmental data and send it via  BlueTooth to your smartphone.
+	* use Time of Flight sensor to detect gestures


I just understood tof means Time of Flight maybe put it here or in the example. Time of Flight (tof)
Or rename to BTLE_sensors_TimeofFligth_demo.ino

ghost · 2017-10-17T12:37:45Z

I2C IT mode available in this PR.

First demo on STM32L475VG-DISCOVERY-IOT board. Demo is using those components : * Low energy Bluetooth (SPBTLE_RF) * temperature and pressure sensor (LPS22HB) * temperature and humidity sensor (HTS221) * Time Of Flight sensor (VL53L0X)

fpistm requested changes Oct 4, 2017

View reviewed changes

VVESTM force-pushed the STM32L475VG-DISCOVERY-IOT branch from b66ee2c to 3fd8773 Compare October 4, 2017 13:07

VVESTM requested review from LMESTM and a user October 9, 2017 12:14

LMESTM reviewed Oct 9, 2017

View reviewed changes

VVESTM force-pushed the STM32L475VG-DISCOVERY-IOT branch from 36c3298 to af006b4 Compare October 10, 2017 07:39

fpistm force-pushed the master branch from 525e336 to a70cecc Compare October 12, 2017 06:56

VVESTM force-pushed the STM32L475VG-DISCOVERY-IOT branch from af006b4 to 049f6f4 Compare October 17, 2017 16:12

ghost approved these changes Oct 20, 2017

View reviewed changes

STM32L475VG-DISCOVERY-IOT : add general demo

a58216d

First demo on STM32L475VG-DISCOVERY-IOT board. Demo is using those components : * Low energy Bluetooth (SPBTLE_RF) * temperature and pressure sensor (LPS22HB) * temperature and humidity sensor (HTS221) * Time Of Flight sensor (VL53L0X)

VVESTM force-pushed the STM32L475VG-DISCOVERY-IOT branch from 049f6f4 to a58216d Compare November 14, 2017 14:12

fpistm approved these changes Nov 14, 2017

View reviewed changes

fpistm merged commit 4891fb3 into stm32duino:master Nov 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32L475VG-DISCOVERY-IOT : add general demo #1

STM32L475VG-DISCOVERY-IOT : add general demo #1

VVESTM commented Oct 2, 2017

fpistm Oct 4, 2017

fpistm Oct 4, 2017

fpistm Oct 4, 2017

fpistm commented Oct 4, 2017

LMESTM Oct 9, 2017

VVESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

VVESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

VVESTM Oct 9, 2017

LMESTM Oct 9, 2017

VVESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

VVESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

LMESTM Oct 9, 2017

ghost commented Oct 17, 2017

STM32L475VG-DISCOVERY-IOT : add general demo #1

STM32L475VG-DISCOVERY-IOT : add general demo #1

Conversation

VVESTM commented Oct 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpistm commented Oct 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Oct 17, 2017